From: Johannes Sixt <j6t@kdbg.org>
Date: Fri, 13 Aug 2010 20:28:40 GMT
Subject: Re: [PATCH v2] test-lib: Multi-prereq support only checked the last prereq
Message-ID: <4C65AAF8.80009@kdbg.org>
In-Reply-To: <1281528278-15659-1-git-send-email-avarab@gmail.com>

Am 11.08.2010 14:04, schrieb Ævar Arnfjörð Bjarmason:
> -		say_color skip "ok $test_count # skip $1 (prereqs: $prereq)"
> +		say_color skip "ok $test_count # skip $1 (missing $missing_prereq of $prereq)"

This needs fixing: When a test is skipped due to being listed in 
GIT_SKIP_TESTS, then the output looks like this:

ok 47 # skip --ignore-submodules=untracked suppresses submodules with 
untracked content (missing SANITY,POSIXPERM of )

(In this case, there was a test before number 47 that was skipped due to 
missing prerequisite.)

Please also note that - when a prerequisite is not satisfied - the text in 
parentheses does not say "prerequisite" or similar anymore. IMO, this 
should be added back.

-- Hannes