Re: [PATCH v2 0/2] clone: simplify progress message
- From
Michael J Gruber <git@drmicha.warpmail.net>
- Date
- May 10, 2010, 10:31 UTC
- Message-ID
- <4BE7E09F.3040303@drmicha.warpmail.net>
- In-Reply-To
- <20100510054756.GB13340@coredump.intra.peff.net>
Jeff King venit, vidit, dixit 10.05.2010 07:47:
Show 18 quoted lines
> On Sun, May 09, 2010 at 01:09:14PM -0700, Pete Harlan wrote: > >>> I guess it comes down to how much detail we want to show. >> >> For me it isn't only a matter of detail; I find "Cloning into >> bar/.git" misleading, since bar is getting more than a .git directory. > > Yeah, I can buy that line of reasoning. Junio's nitpick aside, I think > most users perceive the clone process as creating the whole "bar" > directory. > >> Thank you for looking at this. I agree with you, and have added a >> second patch that implements that. > > These patches look good to me. I agree with Junio about just squashing > them. > > -Peff
Back from a conference, I'm being late for the party (Which way round is better? ;) ).
But I still want to suggest not sacrificing correctness for "user's expectations" and rather trying to do combine them. So how about saying
Cloning into $GIT_DIR... Checking out branch $branch in $WORK_DIR...
where the latter happens for non-bare repos only, of course, and incidently confirms the use of "-b" or of the default.
Michael