git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] clone: simplify progress message

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
May 10, 2010, 10:31 UTC
Message-ID
<4BE7E09F.3040303@drmicha.warpmail.net>
In-Reply-To
<20100510054756.GB13340@coredump.intra.peff.net>
Jeff King venit, vidit, dixit 10.05.2010 07:47:
Show 18 quoted lines
> On Sun, May 09, 2010 at 01:09:14PM -0700, Pete Harlan wrote:
> 
>>> I guess it comes down to how much detail we want to show.
>>
>> For me it isn't only a matter of detail; I find "Cloning into
>> bar/.git" misleading, since bar is getting more than a .git directory.
> 
> Yeah, I can buy that line of reasoning. Junio's nitpick aside, I think
> most users perceive the clone process as creating the whole "bar"
> directory.
> 
>> Thank you for looking at this.  I agree with you, and have added a
>> second patch that implements that.
> 
> These patches look good to me. I agree with Junio about just squashing
> them.
> 
> -Peff

Back from a conference, I'm being late for the party (Which way round is better? ;) ).

But I still want to suggest not sacrificing correctness for "user's expectations" and rather trying to do combine them. So how about saying

Cloning into $GIT_DIR... Checking out branch $branch in $WORK_DIR...

where the latter happens for non-bare repos only, of course, and incidently confirms the use of "-b" or of the default.

Michael
Previous: Jeff KingNext: Michael J Gruber
Message 9 of 14 in “clone: have progress report mention top level dir, not git dir”
  1. clone: have progress report mention top level dir, not git dirPete Harlan, May 9, 2010
  2. Jeff KingMay 9, 2010
  3. 0/2 clone: simplify progress messagePete Harlan, May 9, 2010
  4. 1/2 clone: have progress report mention top level dir, not git dirPete Harlan, May 9, 2010
  5. 2/2 clone: add bare clone to the progress messagePete Harlan, May 9, 2010
  6. Junio C HamanoMay 9, 2010
  7. Pete HarlanMay 9, 2010
  8. Jeff KingMay 10, 2010
  9. Michael J GruberMay 10, 2010
  10. clone: report check out for non-bare clonesMichael J Gruber, May 10, 2010
  11. Junio C HamanoMay 12, 2010
  12. Michael J GruberMay 12, 2010
  13. Pete HarlanMay 10, 2010
  14. Michael J GruberMay 11, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.