Re: [PATCH/RFC] clone: have progress report mention top level dir, not git dir

From: Jeff King <peff@peff.net>
Date: May 9, 2010, 11:02 UTC
Message-ID: <20100509110221.GA16639@coredump.intra.peff.net>
In-Reply-To: <4BE60E89.8010709@pcharlan.com>

On Sat, May 08, 2010 at 06:23:21PM -0700, Pete Harlan wrote:

> "git clone foo bar" currently reports "Cloning into
> /path/to/bar/.git".  Change this message to "Cloning into bar" to more
> closely match the user's expectation.

I am a little torn on this. For most users, it is just another implementation detail that makes git's output more confusing. And it is likely to be the very first git message seen by many people. But at the same time, it is telling you where the repository actually is, which is something that can help users learn about how git works.

I guess it comes down to how much detail we want to show.

Show 8 quoted lines

> For a --bare clone the current message prints the top level dir
> (because that is the git dir), so one could argue in favor of the
> current message because it confirms for the user whether their
> checkout was bare or not.  But that's only if the user is aware of how
> it would appear in both cases; I doubt that the existing code intended
> to make that distinction clear, and in practice I expect most users
> (a) trust git to do what they asked and (b) wouldn't notice that
> "Cloning into /path/to/bar" meant that it was a bare checkout.

I do think there is some value to this distinction. But we can make it a lot less ugly for new users with:

  $ git clone /tmp/foo
  Cloning into /tmp/foo...

  $ git clone --bare /tmp/foo
  Cloning into bare repository /tmp/foo...

or something like that.

-Peff