Re: [PATCH 05/13] Help.c: add list_common_guides_help() function

From: Philip Oakley <philipoakley@iee.org>
Date: Feb 24, 2013, 21:45 UTC
Message-ID: <4AEE9909C70D4810A228A367FB888AF4@PhilipOakley>
In-Reply-To: <7vmwuu5bm1.fsf@alter.siamese.dyndns.org>

From: "Junio C Hamano" <gitster@pobox.com>
Sent: Sunday, February 24, 2013 9:01 AM

Show 12 quoted lines

> Philip Oakley <philipoakley@iee.org> writes:
>
>> diff --git a/common-guides.h b/common-guides.h
>> new file mode 100644
>> index 0000000..a8ad8d1
>> --- /dev/null
>> +++ b/common-guides.h
>> @@ -0,0 +1,12 @@
>> +/* Automatically generated by ./generate-guidelist.sh */
>> +/* re-use struct cmdname_help in common-commands.h */
>
> Huh?

The first comment line fortells of patch 6 which can generate this .h file. The second comment line notes that I re-use cmdname_help, rather than creating another struct with a similar name.

I should probably have noted these points in the commit message. (or waited until patch 6 to add the comment).

Philip