Re: [PATCH 06/13] Add guide-list.txt and extraction shell
- From
W. Trevor King <wking@tremily.us>
- Date
- Feb 24, 2013, 14:51 UTC
- Message-ID
- <20130224145113.GJ1361@odin.tremily.us>
- In-Reply-To
- <1361660761-1932-7-git-send-email-philipoakley@iee.org>
On Sat, Feb 23, 2013 at 11:05:54PM +0000, Philip Oakley wrote:
> +# Usage: ./generate-guidelist.sh >>common-guides.h
Following David's recent series, it's probably better to use a lowercase 'usage' [1]. Also, I'd expect '>common-guides.h' would make more sense than appending with '>>'.
> +/* re-use struct cmdname_help in common-commands.h */
> +
> +static struct cmdname_help common_guides[] = {"This is probably just copied from generate-cmdlist.sh, but maybe it would be a good idea to #include "common-commands.h" here?
Trevor
[1]: http://article.gmane.org/gmane.comp.version-control.git/216961
-- This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy