git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: fix esc_param

From
Stephen Boyd <bebarino@gmail.com>
Date
Oct 14, 2009, 01:13 UTC
Message-ID
<4AD525CA.8090102@gmail.com>
In-Reply-To
<1255463496-21617-1-git-send-email-giuseppe.bilotta@gmail.com>
Giuseppe Bilotta wrote:
Show 10 quoted lines
> The custom CGI escaping done in esc_param failed to escape UTF-8
> properly. Fix by using CGI::escape on each sequence of matched
> characters instead of sprintf()ing a custom escaping for each byte.
>
> Additionally, the space -> + escape was being escaped due to greedy
> matching on the first substitution. Fix by adding space to the
> list of characters not handled on the first substitution.
>
> Finally, remove an unnecessary escaping of the + sign.
>
Signoff?
This works great for my purposes. Thanks.
Previous: Giuseppe BilottaNext: Giuseppe Bilotta
Message 2 of 7 in “gitweb: fix esc_param”
  1. gitweb: fix esc_paramGiuseppe Bilotta, Oct 13, 2009
  2. Stephen BoydOct 14, 2009
  3. Giuseppe BilottaOct 14, 2009
  4. Stephen BoydOct 14, 2009
  5. Jakub NarebskiOct 14, 2009
  6. Jakub NarebskiOct 14, 2009
  7. Junio C HamanoOct 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.