Re: [PATCH] gitweb: fix esc_param

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Oct 14, 2009, 06:19 UTC
Message-ID: <cb7bb73a0910132319p27b4f362sf5bffa2afe6e5849@mail.gmail.com>
In-Reply-To: <4AD525CA.8090102@gmail.com>

On Wed, Oct 14, 2009 at 3:13 AM, Stephen Boyd <bebarino@gmail.com> wrote:

Show 13 quoted lines

> Giuseppe Bilotta wrote:
>> The custom CGI escaping done in esc_param failed to escape UTF-8
>> properly. Fix by using CGI::escape on each sequence of matched
>> characters instead of sprintf()ing a custom escaping for each byte.
>>
>> Additionally, the space -> + escape was being escaped due to greedy
>> matching on the first substitution. Fix by adding space to the
>> list of characters not handled on the first substitution.
>>
>> Finally, remove an unnecessary escaping of the + sign.
>>
>
> Signoff?

Doh.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>

(If this isn't enough, let me know)

> This works great for my purposes. Thanks.

Can you also check if this fixes the branch name issue you mentioned in the other branch? (And/or do you have a repository exposing the problem if not?)

-- 
Giuseppe "Oblomov" Bilotta