From: Stephen Boyd <bebarino@gmail.com>
Date: Wed, 14 Oct 2009 01:13:46 GMT
Subject: Re: [PATCH] gitweb: fix esc_param
Message-ID: <4AD525CA.8090102@gmail.com>
In-Reply-To: <1255463496-21617-1-git-send-email-giuseppe.bilotta@gmail.com>

Giuseppe Bilotta wrote:
> The custom CGI escaping done in esc_param failed to escape UTF-8
> properly. Fix by using CGI::escape on each sequence of matched
> characters instead of sprintf()ing a custom escaping for each byte.
>
> Additionally, the space -> + escape was being escaped due to greedy
> matching on the first substitution. Fix by adding space to the
> list of characters not handled on the first substitution.
>
> Finally, remove an unnecessary escaping of the + sign.
>

Signoff?

This works great for my purposes. Thanks.