Re: [PATCH] git svn: Support multiple branch and tag paths in the svn repository.
- From
Andreas Ericsson <ae@op5.se>
- Date
- Jun 26, 2009, 05:18 UTC
- Message-ID
- <4A445A29.90907@op5.se>
- In-Reply-To
- <20090626003338.GA591@dcvr.yhbt.net>
Eric Wong wrote:
Show 27 quoted lines
> Junio C Hamano <gitster@pobox.com> wrote: >> Eric Wong <normalperson@yhbt.net> writes: >> >>> Acked and and pushed out to git://git.bogomips.org/git-svn along with a >>> followup patch ... >> Hmmm... >> >> t9138-git-svn-multiple-branches.sh does not seem to pass for me. >> >> ... >> A svn_project/tags_A/1.0 >> A svn_project/tags_A/1.0/a.file >> Checked out revision 3. >> ./test-lib.sh: line 329: .: filename argument required >> .: usage: . filename [arguments] >> FATAL: Unexpected exit with code 2 > > Oops, I wasn't reading the test too closely[1], this should fix it: > > From 1ad8ff7b49f508ad37081a709d4230833564eca2 Mon Sep 17 00:00:00 2001 > From: Eric Wong <normalperson@yhbt.net> > Date: Thu, 25 Jun 2009 16:09:59 -0700 > Subject: [PATCH] t9138: remove stray "." in tests > > This breaks bash and probably some other shells, but worked > fine with dash in my limited testing. >
Please reword to "The stray dots break bash and ..." Right now it reads as if the patch itself breaks bash et al.
-- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 Considering the successes of the wars on alcohol, poverty, drugs and terror, I think we should give some serious thought to declaring war on peace.