Re: [PATCH] git svn: Support multiple branch and tag paths in the svn repository.
- From
- Eric Wong <normalperson@yhbt.net>
- Date
- Jun 26, 2009, 00:33 UTC
- Message-ID
- <20090626003338.GA591@dcvr.yhbt.net>
- In-Reply-To
- <7v3a9o0x48.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
Show 16 quoted lines
> Eric Wong <normalperson@yhbt.net> writes: > > > Acked and and pushed out to git://git.bogomips.org/git-svn along with a > > followup patch ... > > Hmmm... > > t9138-git-svn-multiple-branches.sh does not seem to pass for me. > > ... > A svn_project/tags_A/1.0 > A svn_project/tags_A/1.0/a.file > Checked out revision 3. > ./test-lib.sh: line 329: .: filename argument required > .: usage: . filename [arguments] > FATAL: Unexpected exit with code 2
Oops, I wasn't reading the test too closely[1], this should fix it:
>From 1ad8ff7b49f508ad37081a709d4230833564eca2 Mon Sep 17 00:00:00 2001
From: Eric Wong <normalperson@yhbt.net> Date: Thu, 25 Jun 2009 16:09:59 -0700 Subject: [PATCH] t9138: remove stray "." in tests
This breaks bash and probably some other shells, but worked fine with dash in my limited testing.
Signed-off-by: Eric Wong <normalperson@yhbt.net> --- t/t9138-git-svn-multiple-branches.sh | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/t/t9138-git-svn-multiple-branches.sh b/t/t9138-git-svn-multiple-branches.sh index 9725ccf..37ecdb0 100755 --- a/t/t9138-git-svn-multiple-branches.sh +++ b/t/t9138-git-svn-multiple-branches.sh @@ -22,7 +22,6 @@ test_expect_success 'setup svnrepo' ' "$svnrepo/project/tags_A/1.0" && svn co "$svnrepo/project" svn_project && cd svn_project && - . echo 2 > trunk/a.file && svn ci -m "Change 1" trunk/a.file && svn cp -m "Branch 2" "$svnrepo/project/trunk" \
-- Eric Wong [1] - the test should use the new svn_cmd wrapper and avoid cd + cd .. which is more error prone than (cd ). I'll try to find time to fix it later tonight.