Re: [PATCH] git svn: Support multiple branch and tag paths in the svn repository.

From: Eric Wong <normalperson@yhbt.net>
Date: Jun 26, 2009, 18:11 UTC
Message-ID: <20090626181100.GA25118@dcvr.yhbt.net>
In-Reply-To: <4A445A29.90907@op5.se>

Andreas Ericsson <ae@op5.se> wrote:

Show 30 quoted lines

> Eric Wong wrote:
>> Junio C Hamano <gitster@pobox.com> wrote:
>>> Eric Wong <normalperson@yhbt.net> writes:
>>>
>>>> Acked and and pushed out to git://git.bogomips.org/git-svn along with a
>>>> followup patch ...
>>> Hmmm...
>>>
>>> t9138-git-svn-multiple-branches.sh does not seem to pass for me.
>>>
>>>     ...
>>>     A    svn_project/tags_A/1.0
>>>     A    svn_project/tags_A/1.0/a.file
>>>     Checked out revision 3.
>>>     ./test-lib.sh: line 329: .: filename argument required
>>>     .: usage: . filename [arguments]
>>>     FATAL: Unexpected exit with code 2
>>
>> Oops, I wasn't reading the test too closely[1], this should fix it:
>>
>> From 1ad8ff7b49f508ad37081a709d4230833564eca2 Mon Sep 17 00:00:00 2001
>> From: Eric Wong <normalperson@yhbt.net>
>> Date: Thu, 25 Jun 2009 16:09:59 -0700
>> Subject: [PATCH] t9138: remove stray "." in tests
>>
>> This breaks bash and probably some other shells, but worked
>> fine with dash in my limited testing.
>
> Please reword to "The stray dots break bash and ..."
> Right now it reads as if the patch itself breaks bash et al.

Oops, reworded to:

    t9138: remove stray dot in test which broke bash

    The stray dot broke bash and probably some other shells,
    but worked fine with dash in my limited testing.

And pushed out to git://git.bogomips.org/git-svn

There's also some other changes in there that have been sitting a while that may have been lost in the shuffle in the weeks I was offline:

Ben Jackson (3):
      Add 'git svn help [cmd]' which works outside a repo.
      git-svn: speed up find_rev_before
      Add 'git svn reset' to unwind 'git svn fetch'

Eric Wong (2):
      git-svn: convert globs to regexps for branch destinations
      t9138: remove stray dot in test which broke bash

Marc Branchaud (1):
      git svn: Support multiple branch and tag paths in the svn repository.

Thomas Rast (1):
      git-svn: let 'dcommit $rev' work on $rev instead of HEAD

-- 
Eric Wong