git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/6] Add core.autocrlf=true on cygwin by default during tests

From
DSDon Slutz <don.slutz@sierraatlantic.com>
Date
May 12, 2009, 18:16 UTC
Message-ID
<4A09BCFC.4080307@SierraAtlantic.com>
In-Reply-To
<alpine.DEB.1.00.0905112253580.27348@pacific.mpi-cbg.de>
Based on:
On 5/11/2009 4:54 PM, Johannes Schindelin wrote:
Show 21 quoted lines
> Hi,
>
> On Mon, 11 May 2009, Don Slutz wrote:
>
>   
>> This is a patch set to do the work from mail message:
>>
>> http://kerneltrap.org/mailarchive/git/2007/8/7/254415
>>
>> It is split into 6 parts.  This is because the tests do not work on
>> Linux if autocrlf=true.
>>
>> 1) The change to autocrlf=true by default for cygwin
>>     
>
> From the fallout of our unilateral decision in msysGit to set 
> autoCRLF=true all the time, I would advise against this change.
>
> Ciao,
> Dscho
>   
On 5/11/2009 4:04 PM, Eric Blake wrote:
Show 25 quoted lines
> Don Slutz <Don.Slutz <at> SierraAtlantic.com> writes:
>
>   
>> This is a patch set to do the work from mail message:
>>
>> http://kerneltrap.org/mailarchive/git/2007/8/7/254415
>>
>> It is split into 6 parts.  This is because the tests do not work on
>> Linux if autocrlf=true.
>>
>> 1) The change to autocrlf=true by default for cygwin
>>     
>
> I help maintain the cygwin packaging of git, and I don't particularly like 
> patch 1/6.  Cygwin very much recommends that users stick with binary mounts, 
> where cr's are not inserted/stripped by default, and enabling autocrlf in that 
> situation is asking for problems (namely, the same set of problems as you would 
> have on Linux with autocrlf=true).  While adding an environment variable is 
> useful for the case of a user building git on cygwin with the intent of using a 
> text-mode mount, it goes against the grain of cygwin's recommendation of not 
> using text-mode mounts in the first place.  I would rather see the default 
> remain false, even on cygwin, unless the person building git takes steps to 
> activate it themselves.
>
>   
I will change 1/6 into adding the environment variable without the 
default change. v2 sometime soon.
   -Don

__________________________________________________________________________________________________________________ DISCLAIMER:"The information contained in this message and the attachments (if any) may be privileged and confidential and protected from disclosure. You are hereby notified that any unauthorized use, dissemination, distribution or copying of this communication, review, retransmission, or taking of any action based upon this information, by persons or entities other than the intended recipient, is strictly prohibited. If you are not the intended recipient or an employee or agent responsible for delivering this message, and have received this communication in error, please notify us immediately by replying to the message and kindly delete the original message, attachments, if any, and all its copies from your computer system. Thank you for your cooperation." ________________________________________________________________________________________________________________

Previous: Johannes SchindelinNext: Don Slutz
Message 14 of 24 in “Add core.autocrlf=true on cygwin by default during tests”
  1. 0/6 Add core.autocrlf=true on cygwin by default during testsDon Slutz, May 11, 2009
  2. 1/6 Add core.autocrlf=true on cygwin by default during testsDon Slutz, May 11, 2009
  3. 2/6 Fix tests to work with core.autocrlf=trueDon Slutz, May 11, 2009
  4. 3/6 Fix tests to work with core.autocrlf=trueDon Slutz, May 11, 2009
  5. 4/6 Fix tests to work with core.autocrlf=trueDon Slutz, May 11, 2009
  6. 5/6 Fix tests to work with core.autocrlf=trueDon Slutz, May 11, 2009
  7. 6/6 Add 'make test-text'Don Slutz, May 11, 2009
  8. Charles BaileyMay 11, 2009
  9. Don SlutzMay 14, 2009
  10. Eric BlakeMay 11, 2009
  11. Junio C HamanoMay 12, 2009
  12. Junio C HamanoMay 13, 2009
  13. Johannes SchindelinMay 11, 2009
  14. Don SlutzMay 12, 2009
  15. 0/7 Add GIT_TEST_AUTO_CRLF environment variable to set core.autocrlf on initDon Slutz, May 13, 2009
  16. 1/7 Add GIT_TEST_AUTO_CRLF environment variable to set core.autocrlf on initDon Slutz, May 13, 2009
  17. 2/7 Add support functions for tests in core.autocrlf=trueDon Slutz, May 13, 2009
  18. 3/7 Fix tests to work with core.autocrlf=true -- new functionsDon Slutz, May 13, 2009
  19. 4/7 Fix tests to work with core.autocrlf=true -- force falseDon Slutz, May 13, 2009
  20. 5/7 Fix tests to work with core.autocrlf=true -- cmp to test_cmpDon Slutz, May 13, 2009
  21. 6/7 Fix tests to work with core.autocrlf=true -- test_cmp to cmpDon Slutz, May 13, 2009
  22. 7/7 Add 'make test-text' core.autocrlf=trueDon Slutz, May 13, 2009
  23. Charles BaileyMay 14, 2009
  24. Don SlutzMay 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.