git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/6] Add core.autocrlf=true on cygwin by default during tests

From
Eric Blake <ebb9@byu.net>
Date
May 11, 2009, 20:04 UTC
Message-ID
<loom.20090511T195910-370@post.gmane.org>
In-Reply-To
<1242070141-2936-1-git-send-email-Don.Slutz@SierraAtlantic.com>
Don Slutz <Don.Slutz <at> SierraAtlantic.com> writes:
Show 9 quoted lines
> 
> This is a patch set to do the work from mail message:
> 
> http://kerneltrap.org/mailarchive/git/2007/8/7/254415
> 
> It is split into 6 parts.  This is because the tests do not work on
> Linux if autocrlf=true.
> 
> 1) The change to autocrlf=true by default for cygwin

I help maintain the cygwin packaging of git, and I don't particularly like patch 1/6. Cygwin very much recommends that users stick with binary mounts, where cr's are not inserted/stripped by default, and enabling autocrlf in that situation is asking for problems (namely, the same set of problems as you would have on Linux with autocrlf=true). While adding an environment variable is useful for the case of a user building git on cygwin with the intent of using a text-mode mount, it goes against the grain of cygwin's recommendation of not using text-mode mounts in the first place. I would rather see the default remain false, even on cygwin, unless the person building git takes steps to activate it themselves.

-- 
Eric Blake
Previous: Don SlutzNext: Junio C Hamano
Message 10 of 24 in “Add core.autocrlf=true on cygwin by default during tests”
  1. 0/6 Add core.autocrlf=true on cygwin by default during testsDon Slutz, May 11, 2009
  2. 1/6 Add core.autocrlf=true on cygwin by default during testsDon Slutz, May 11, 2009
  3. 2/6 Fix tests to work with core.autocrlf=trueDon Slutz, May 11, 2009
  4. 3/6 Fix tests to work with core.autocrlf=trueDon Slutz, May 11, 2009
  5. 4/6 Fix tests to work with core.autocrlf=trueDon Slutz, May 11, 2009
  6. 5/6 Fix tests to work with core.autocrlf=trueDon Slutz, May 11, 2009
  7. 6/6 Add 'make test-text'Don Slutz, May 11, 2009
  8. Charles BaileyMay 11, 2009
  9. Don SlutzMay 14, 2009
  10. Eric BlakeMay 11, 2009
  11. Junio C HamanoMay 12, 2009
  12. Junio C HamanoMay 13, 2009
  13. Johannes SchindelinMay 11, 2009
  14. Don SlutzMay 12, 2009
  15. 0/7 Add GIT_TEST_AUTO_CRLF environment variable to set core.autocrlf on initDon Slutz, May 13, 2009
  16. 1/7 Add GIT_TEST_AUTO_CRLF environment variable to set core.autocrlf on initDon Slutz, May 13, 2009
  17. 2/7 Add support functions for tests in core.autocrlf=trueDon Slutz, May 13, 2009
  18. 3/7 Fix tests to work with core.autocrlf=true -- new functionsDon Slutz, May 13, 2009
  19. 4/7 Fix tests to work with core.autocrlf=true -- force falseDon Slutz, May 13, 2009
  20. 5/7 Fix tests to work with core.autocrlf=true -- cmp to test_cmpDon Slutz, May 13, 2009
  21. 6/7 Fix tests to work with core.autocrlf=true -- test_cmp to cmpDon Slutz, May 13, 2009
  22. 7/7 Add 'make test-text' core.autocrlf=trueDon Slutz, May 13, 2009
  23. Charles BaileyMay 14, 2009
  24. Don SlutzMay 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.