From: Don Slutz Date: Tue, 12 May 2009 18:16:28 GMT Subject: Re: [PATCH 0/6] Add core.autocrlf=true on cygwin by default during tests Message-ID: <4A09BCFC.4080307@SierraAtlantic.com> In-Reply-To: Based on: On 5/11/2009 4:54 PM, Johannes Schindelin wrote: > Hi, > > On Mon, 11 May 2009, Don Slutz wrote: > > >> This is a patch set to do the work from mail message: >> >> http://kerneltrap.org/mailarchive/git/2007/8/7/254415 >> >> It is split into 6 parts. This is because the tests do not work on >> Linux if autocrlf=true. >> >> 1) The change to autocrlf=true by default for cygwin >> > > From the fallout of our unilateral decision in msysGit to set > autoCRLF=true all the time, I would advise against this change. > > Ciao, > Dscho > On 5/11/2009 4:04 PM, Eric Blake wrote: > Don Slutz SierraAtlantic.com> writes: > > >> This is a patch set to do the work from mail message: >> >> http://kerneltrap.org/mailarchive/git/2007/8/7/254415 >> >> It is split into 6 parts. This is because the tests do not work on >> Linux if autocrlf=true. >> >> 1) The change to autocrlf=true by default for cygwin >> > > I help maintain the cygwin packaging of git, and I don't particularly like > patch 1/6. Cygwin very much recommends that users stick with binary mounts, > where cr's are not inserted/stripped by default, and enabling autocrlf in that > situation is asking for problems (namely, the same set of problems as you would > have on Linux with autocrlf=true). While adding an environment variable is > useful for the case of a user building git on cygwin with the intent of using a > text-mode mount, it goes against the grain of cygwin's recommendation of not > using text-mode mounts in the first place. I would rather see the default > remain false, even on cygwin, unless the person building git takes steps to > activate it themselves. > > I will change 1/6 into adding the environment variable without the default change. v2 sometime soon. -Don __________________________________________________________________________________________________________________ DISCLAIMER:"The information contained in this message and the attachments (if any) may be privileged and confidential and protected from disclosure. You are hereby notified that any unauthorized use, dissemination, distribution or copying of this communication, review, retransmission, or taking of any action based upon this information, by persons or entities other than the intended recipient, is strictly prohibited. If you are not the intended recipient or an employee or agent responsible for delivering this message, and have received this communication in error, please notify us immediately by replying to the message and kindly delete the original message, attachments, if any, and all its copies from your computer system. Thank you for your cooperation." ________________________________________________________________________________________________________________