Re: [PATCH 1/2] Documentation: replace sha1 by SHA-1

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Apr 24, 2009, 15:30 UTC
Message-ID: <49F1DB26.1070605@drmicha.warpmail.net>
In-Reply-To: <49F1D857.7060100@viscovery.net>

Johannes Sixt venit, vidit, dixit 24.04.2009 17:18:

Show 7 quoted lines

> Michael J Gruber schrieb:
>> diff --git a/Documentation/git-fsck.txt b/Documentation/git-fsck.txt
>> index 287c4fc..73e1dc4 100644
>> --- a/Documentation/git-fsck.txt
>> +++ b/Documentation/git-fsck.txt
> 
> These hunks are in a section that talks about fsck's diagnostics.

Yes. I didn't notice they were actual warning message quotes though. Thanks for catching it.

Show 6 quoted lines

> 
>> +missing SHA-1 directory '<dir>'::
>> +	The directory holding the SHA-1 objects is missing.
> 
> This message does not present in the code anywhere; it could be removed
> from this list.

Yes, that should be a patch before 1/2 then.

> 
>> +SHA-1 mismatch <object>::
> 
> And this one occurs in the code, and so it should be changed as well.

It comes from object.c rather than builtin-fsck.c, right?

I guess it shows that I should go through the code as well. But it's not a good time for that now... (rc) I'll revert that specific change then.

Michael