Re: [PATCH 2/2] Documentation: replace SHA1 by SHA-1

From: Jeff King <peff@peff.net>
Date: Apr 24, 2009, 21:30 UTC
Message-ID: <20090424213056.GC14435@coredump.intra.peff.net>
In-Reply-To: <1240584575-5702-3-git-send-email-git@drmicha.warpmail.net>

On Fri, Apr 24, 2009 at 04:49:35PM +0200, Michael J Gruber wrote:

Show 11 quoted lines

> --- a/Documentation/git-pack-objects.txt
> +++ b/Documentation/git-pack-objects.txt
> @@ -47,7 +47,7 @@ base-name::
>  	Write into a pair of files (.pack and .idx), using
>  	<base-name> to determine the name of the created file.
>  	When this option is used, the two files are written in
> -	<base-name>-<SHA1>.{pack,idx} files.  <SHA1> is a hash
> +	<base-name>-<SHA-1>.{pack,idx} files.  <SHA-1> is a hash
>  	of the sorted object names to make the resulting filename
>  	based on the pack content, and written to the standard
>  	output of the command.

Same complaint as the last patch. The extra hyphen is really distracting, as it is in the midst of an already hyphenated filename. Interestingly, I don't find <base-name> as bad. I think it is because the single numeric character with the punctuation is just hard on the eyes.

-Peff