git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] rev-list: embed "struct rev_info revs" into "struct rev_list_info"

From
Paolo Bonzini <bonzini@gnu.org>
Date
Apr 18, 2009, 10:56 UTC
Message-ID
<49E9B1C4.50100@gnu.org>
In-Reply-To
<20090418191125.6117@nanako3.lavabit.com>
Nanako Shiraishi wrote:
Show 7 quoted lines
> Quoting Christian Couder <chriscool@tuxfamily.org>:
> 
>> There are downsides to this patch. First it is big. And "revs" is
>> initialized once when doing "memset(&info, 0, sizeof(info))" and
>> once in "init_revisions".
> 
> I'm sorry if it is obvious, but is there any upsides?

As the patch shows, the lifetime of the revs is the same as that of info (i.e., there are never memcpys from something into revs).

Paolo
Previous: Nanako Shiraishi
Message 3 of 3 in “rev-list: embed "struct rev_info revs" into "struct rev_list_info"”
  1. rev-list: embed "struct rev_info revs" into "struct rev_list_info"Christian Couder, Apr 18, 2009
  2. Nanako ShiraishiApr 18, 2009
  3. Paolo BonziniApr 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.