From: Paolo Bonzini <bonzini@gnu.org>
Date: Sat, 18 Apr 2009 10:56:04 GMT
Subject: Re: [RFC/PATCH] rev-list: embed "struct rev_info revs" into "struct rev_list_info"
Message-ID: <49E9B1C4.50100@gnu.org>
In-Reply-To: <20090418191125.6117@nanako3.lavabit.com>

Nanako Shiraishi wrote:
> Quoting Christian Couder <chriscool@tuxfamily.org>:
> 
>> There are downsides to this patch. First it is big. And "revs" is
>> initialized once when doing "memset(&info, 0, sizeof(info))" and
>> once in "init_revisions".
> 
> I'm sorry if it is obvious, but is there any upsides?

As the patch shows, the lifetime of the revs is the same as that of info
(i.e., there are never memcpys from something into revs).

Paolo