Re: [RFC/PATCH] rev-list: embed "struct rev_info revs" into "struct rev_list_info"
- From
Nanako Shiraishi <nanako3@lavabit.com>
- Date
- Apr 18, 2009, 10:11 UTC
- Message-ID
- <20090418191125.6117@nanako3.lavabit.com>
- In-Reply-To
- <20090418064328.ad64accf.chriscool@tuxfamily.org>
Quoting Christian Couder <chriscool@tuxfamily.org>:
> There are downsides to this patch. First it is big. And "revs" is > initialized once when doing "memset(&info, 0, sizeof(info))" and > once in "init_revisions".
I'm sorry if it is obvious, but is there any upsides?
-- Nanako Shiraishi http://ivory.ap.teacup.com/nanako3/