git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Fix buffer overflow in config parser

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Apr 15, 2009, 07:39 UTC
Message-ID
<49E58F38.5060103@viscovery.net>
In-Reply-To
<49E5888D.2090607@viscovery.net>
Johannes Sixt schrieb:
Show 15 quoted lines
> Junio C Hamano schrieb:
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>
>>> Hi,
>>>
>>> On Tue, 14 Apr 2009, Thomas Jarosch wrote:
>>>
>>>>  t/t1303-wacky-config.sh |    9 ++++++++-
>>> I like the name!
>>>
>>>> +LONG_VALUE=`perl -e 'print "x" x 1023," a"'`
>>> But should it not be guarded against NO_PERL?
>> The right question to ask is a rhetorical "do we need perl to do this?"
> 
> LONG_VALUE=$(printf "x%0.1021dx a", 7)
Oops! Make this
LONG_VALUE=$(printf "x%01021dx a" 7)
-- Hannes
Previous: Johannes SixtNext: Thomas Jarosch
Message 8 of 10 in “Fix buffer overflow in config parser”
  1. Fix buffer overflow in config parserThomas Jarosch, Apr 14, 2009
  2. Johannes SchindelinApr 14, 2009
  3. Thomas JaroschApr 14, 2009
  4. Jeff KingApr 15, 2009
  5. Jeff KingApr 15, 2009
  6. Junio C HamanoApr 14, 2009
  7. Johannes SixtApr 15, 2009
  8. Johannes SixtApr 15, 2009
  9. Fix buffer overflow in config parserThomas Jarosch, Apr 17, 2009
  10. Johannes SchindelinApr 17, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.