Re: [PATCH v2] Fix buffer overflow in config parser

From: Jeff King <peff@peff.net>
Date: Apr 15, 2009, 07:50 UTC
Message-ID: <20090415075035.GA23332@coredump.intra.peff.net>
In-Reply-To: <49E50480.5060005@intra2net.com>

On Tue, Apr 14, 2009 at 11:47:44PM +0200, Thomas Jarosch wrote:

Show 7 quoted lines

> Johannes Schindelin wrote:
> >> +LONG_VALUE=`perl -e 'print "x" x 1023," a"'`
> > 
> > But should it not be guarded against NO_PERL?
> 
> Hmm, lots of other tests like "t4200-rerere.sh" use perl
> and it don't see any special guard around the perl usage.

Right.  There are really two types of perl usage in the tests:

  1. Testing git programs which use perl.

  2. Tests which happen to require perl as part of the testing.

Right now, only instances of (1) are marked with NO_PERL. This means that you can build with NO_PERL, test and install the result, and then uninstall perl (or make a binary package for perl-less people), and have it work fine. But you can't currently run the full test suite without any perl.

Your usage falls into (2), none of which are marked (and if they are to be marked, then all of them should be, since there is otherwise no point).

-Peff