git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] assertion failure in builtin-mv.c with "git mv -k"

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Jan 14, 2009, 16:04 UTC
Message-ID
<496E0D1C.20807@drmicha.warpmail.net>
In-Reply-To
<alpine.DEB.1.00.0901141653540.3586@pacific.mpi-cbg.de>
Johannes Schindelin venit, vidit, dixit 14.01.2009 16:54:
Show 13 quoted lines
> Hi,
> 
> On Wed, 14 Jan 2009, Michael J Gruber wrote:
> 
>> I'll send a patch but I'm not sure if this needs a test case.
> 
> Umm, Michael, you have been here long enough to know that the answer is a 
> "YES!".  If you fix something, you want to provide a test case just to 
> make sure you do not need to fix it again later.
> 
> Ciao,
> Dscho
>

It was a lame attempt at getting around it, it's just one line... I didn't know I've been being noticed long enough ;) So, should I prepare a series like:

1: test case and mark known fail 2: the 1 line fix 3: mark test pass

Or should 2+3 be squashed into one?

Cheers, Michael

Previous: Johannes SchindelinNext: Jeff King
Message 4 of 14 in “[BUG] assertion failure in builtin-mv.c with "git mv -k"”
  1. Matthieu MoyJan 14, 2009
  2. Michael J GruberJan 14, 2009
  3. Johannes SchindelinJan 14, 2009
  4. Michael J GruberJan 14, 2009
  5. Jeff KingJan 14, 2009
  6. Junio C HamanoJan 14, 2009
  7. Michael J GruberJan 15, 2009
  8. Junio C HamanoJan 15, 2009
  9. Matthieu MoyJan 16, 2009
  10. 0/3 Add test cases for "git mv -k" and fix a known breakage.Michael J Gruber, Jan 14, 2009
  11. 1/3 add test cases for "git mv -k"Michael J Gruber, Jan 14, 2009
  12. 2/3 fix handling of multiple untracked files for git mv -kMichael J Gruber, Jan 14, 2009
  13. 3/3 mark fixed breakage as expect pass for "git mv -k" multiple filesMichael J Gruber, Jan 14, 2009
  14. fix handling of multiple untracked files for git mv -kMichael J Gruber, Jan 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.