git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/3] fix handling of multiple untracked files for git mv -k

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Jan 14, 2009, 17:03 UTC
Message-ID
<1231952603-32527-3-git-send-email-git@drmicha.warpmail.net>
In-Reply-To
<1231952603-32527-2-git-send-email-git@drmicha.warpmail.net>

The "-k" option to "git mv" should allow specifying multiple untracked files. Currently, multiple untracked files raise an assertion if they appear consecutively as arguments. Fix this by decrementing the loop index after removing one entry from the array of arguments.

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
 builtin-mv.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/builtin-mv.c b/builtin-mv.c
index 4f65b5a..bce9959 100644
--- a/builtin-mv.c
+++ b/builtin-mv.c
@@ -192,6 +192,7 @@ int cmd_mv(int argc, const char **argv, const char *prefix)
 					memmove(destination + i,
 						destination + i + 1,
 						(argc - i) * sizeof(char *));
+					i--;
 				}
 			} else
 				die ("%s, source=%s, destination=%s",
-- 
1.6.0.6
Previous: Michael J GruberNext: Michael J Gruber
Message 12 of 14 in “[BUG] assertion failure in builtin-mv.c with "git mv -k"”
  1. Matthieu MoyJan 14, 2009
  2. Michael J GruberJan 14, 2009
  3. Johannes SchindelinJan 14, 2009
  4. Michael J GruberJan 14, 2009
  5. Jeff KingJan 14, 2009
  6. Junio C HamanoJan 14, 2009
  7. Michael J GruberJan 15, 2009
  8. Junio C HamanoJan 15, 2009
  9. Matthieu MoyJan 16, 2009
  10. 0/3 Add test cases for "git mv -k" and fix a known breakage.Michael J Gruber, Jan 14, 2009
  11. 1/3 add test cases for "git mv -k"Michael J Gruber, Jan 14, 2009
  12. 2/3 fix handling of multiple untracked files for git mv -kMichael J Gruber, Jan 14, 2009
  13. 3/3 mark fixed breakage as expect pass for "git mv -k" multiple filesMichael J Gruber, Jan 14, 2009
  14. fix handling of multiple untracked files for git mv -kMichael J Gruber, Jan 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.