From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Wed, 14 Jan 2009 16:04:44 GMT
Subject: Re: [BUG] assertion failure in builtin-mv.c with "git mv -k"
Message-ID: <496E0D1C.20807@drmicha.warpmail.net>
In-Reply-To: <alpine.DEB.1.00.0901141653540.3586@pacific.mpi-cbg.de>

Johannes Schindelin venit, vidit, dixit 14.01.2009 16:54:
> Hi,
> 
> On Wed, 14 Jan 2009, Michael J Gruber wrote:
> 
>> I'll send a patch but I'm not sure if this needs a test case.
> 
> Umm, Michael, you have been here long enough to know that the answer is a 
> "YES!".  If you fix something, you want to provide a test case just to 
> make sure you do not need to fix it again later.
> 
> Ciao,
> Dscho
> 

It was a lame attempt at getting around it, it's just one line... I
didn't know I've been being noticed long enough ;)
So, should I prepare a series like:

1: test case and mark known fail
2: the 1 line fix
3: mark test pass

Or should 2+3 be squashed into one?

Cheers,
Michael