Re: [PATCH 2] count-objects: add human-readable size option

From: Marcus Griep <marcus@griep.us>
Date: Aug 14, 2008, 04:44 UTC
Message-ID: <48A3B81B.10804@griep.us>
In-Reply-To: <20080814043817.GC11232@spearce.org>

Shawn O. Pearce wrote:

Show 13 quoted lines

> Hmm.  This probably should be static.  Or if it really is meant
> to be a utility for use elsewhere in Git, moved to someplace where
> string handling is done.  Its not strbuf related, but maybe strbuf.c
> is a better location for this sort of library function.
> 
> If you do move this to strbuf.c, how about having it take a strbuf
> in and appending the formatted text onto it?  You'll neer have to
> worry about the buffer being too small and it fits into the whole
> strbuf.c module thing.
> 
> If you keep this static here in builtin-count-objects.c, how about
> making the char *buf static scoped to the function, so you don't
> need to pass the buffer, its size, nor check its size?

I'll take this into account. Though I didn't plan it to be a cross-git utility function, it probably could be, so I'll look at putting it in strbuf.c.

> We don't declare variables after statements.  Please declare all
> variables at the start of the block as not all compilers we support
> support this C99 syntax.

This is the first time I've hacked on vanilla-C in about 5 years, so I'm quite rusty. Much less my first time hacking on perl, ever, in the case of git-svn. Thanks for the pointers.

> Oh, and welcome to Git.  I saw your SVN patches.  Glad to see
> you hacking.  ;-)

Glad to be a part.

-- 
Marcus Griep
GPG Key ID: 0x5E968152
——
http://www.boohaunt.net
את.ψο´