Re: [PATCH 2] count-objects: add human-readable size option

From: Petr Baudis <pasky@suse.cz>
Date: Aug 14, 2008, 15:14 UTC
Message-ID: <20080814151451.GA10544@machine.or.cz>
In-Reply-To: <1218687684-11671-1-git-send-email-marcus@griep.us>

On Thu, Aug 14, 2008 at 12:21:24AM -0400, Marcus Griep wrote:

Show 16 quoted lines

> +void human_readable_size(char *buf, int buf_size, double size /* in bytes */)
> +{
> +	char human_readable_prefixes[10] = "BKMGTPEZY";
> +	if (buf_size < 5)
> +		die("insufficient buffer size");
> +	int i = 0;
> +	for (; i < 8 && size >= 1000 ; ++i, size = size / 1024)
> +		;
> +	if (size >= 1000)
> +		die("size greater than 999Y");
> +	sprintf(buf, "%.*f%c",
> +		size < 10 ? 1 : 0,
> +		size,
> +		human_readable_prefixes[i]
> +		);
> +}

Are you aware of progress.c:throughput_string()? It would make sense to use the same code in both instances.

I'd prefer you to keep using binary units instead of the ambiguous prefixes, since we should keep our output consistent and I believe they usually end up to be the least confusing choice. (Otherwise, don't you want to use "bkM" instead of "BKM"? I never really know.)

-- 
				Petr "Pasky" Baudis
The next generation of interesting software will be done
on the Macintosh, not the IBM PC.  -- Bill Gates