Re: [PATCH 1/3] Git.pm: Add faculties to allow temp files to be cached
Yeesh; didn't realize it would create that heavy of a dependency. Perhaps this should be split into a submodule so that Git.pm doesn't require the newer dependency. Eric/Junio?
Lea Wiemann wrote:
Show 15 quoted lines
> Marcus Griep wrote:
>> diff --git a/perl/Git.pm b/perl/Git.pm
>>
>> +require File::Spec;
>
> This makes Git.pm dependent on Perl 5.6.1. Some tests (like
> t3701-add-interactive.sh) seem to work with pretty much any Perl version
> out there, and requiring File::Spec changes this. Hence to avoid
> complaints about failing tests, I suggest that you add a check for
> File::Spec availability at the beginning of any test that (indirectly)
> uses Git.pm.
>
> (All my statements are untested... ;-))
>
> -- Lea
--
Marcus Griep
GPG Key ID: 0x5E968152
——
http://www.boohaunt.net
את.ψο´
Marcus Griep <marcus@griep.us>