Re: [PATCH 3/3] git-svn: Reduce temp file usage when dealing with non-links

From: Eric Wong <normalperson@yhbt.net>
Date: Aug 12, 2008, 03:37 UTC
Message-ID: <20080812033700.GC14051@untitled>
In-Reply-To: <1218470035-13864-4-git-send-email-marcus@griep.us>

Marcus Griep <marcus@griep.us> wrote:

Show 19 quoted lines

> Currently, in sub 'close_file', git-svn creates a temporary file and
> copies the contents of the blob to be written into it. This is useful
> for symlinks because svn stores symlinks in the form:
> 
> link $FILE_PATH
> 
> Git creates a blob only out of '$FILE_PATH' and uses file mode to
> indicate that the blob should be interpreted as a symlink.
> 
> As git-hash-object is invoked with --stdin-paths, a duplicate of the
> link from svn must be created that leaves off the first five bytes,
> i.e. 'link '. However, this is wholly unnecessary for normal blobs,
> though, as we already have a temp file with their contents. Copying
> the entire file gains nothing, and effectively requires a file to be
> written twice before making it into the object db.
> 
> This patch corrects that issue, holding onto the substr-like
> duplication for symlinks, but skipping it altogether for normal blobs
> by reusing the existing temp file.

Sweet optimization!  Thanks!

One thing, again, can you please make sure things don't exceed 80-columns when using 8 character-wide tabs?

I'm not sure how much it matters to the guys maintaining Git.pm, but that's the standard for here and the Linux kernel (although it unfortunately seems to have gotten more lax in recent years...).

Larger monitors can't help me because I use big fonts that would require me to move my neck or eyes to see across the screen, leading to more eye and neck strain (I have a bad neck). I very much wish ANSI had standardized on something even smaller, perhaps 64-char wide terminals :)

-- 
Eric Wong