Re: [PATCH 2/3] git-svn: Make it scream by minimizing temp files
- From
Marcus Griep <marcus@griep.us>
- Date
- Aug 12, 2008, 15:50 UTC
- Message-ID
- <48A1B13E.2050603@griep.us>
- In-Reply-To
- <20080812031442.GB14051@untitled>
Eric Wong wrote:
> The above is dead code now that we're using the versions in Git::, > right? > > Why create a temporary variable? (and break the sacred 80-column limit).
My cherry-picking & squashing skills are not yet up to snuff. The dead code and unnecessary variable have now been removed.
> I missed this before, but $tmp_fh->filename doesn't interpolate correctly.
Show 7 quoted lines
>
> ("write ${\$tmp_fh->filename}: $!\n")
> or
> ("write ", $tmp_fh->filename, ": $!\n") works.
>
> I believe the latter form is more idiomatic so we should probably use
> that...Done, in the latter form, and fixed in a couple other places.
-- Marcus Griep GPG Key ID: 0x5E968152 —— http://www.boohaunt.net את.ψο´