git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH (GITK BUGFIX)] gitk: Allow safely calling nukefile from a run queue handler.

From
CJChristian Jaeger <christian@jaeger.mine.nu>
Date
Aug 9, 2008, 11:24 UTC
Message-ID
<489D7E67.5050205@jaeger.mine.nu>
In-Reply-To
<200808091441.50444.angavrilov@gmail.com>
Alexander Gavrilov wrote:
> 	Please test if this patch fixes it.
>   
Yes, with that patch it works reliably.
BTW here's a patch to your patch to make it apply on top of 1.6.0.rc2:

--- patch.eml.1 2008-08-09 13:17:30.000000000 +0200 +++ patch.eml 2008-08-09 13:14:22.000000000 +0200

@@ -96,10 +96,10 @@
  gitk |   14 ++++++++------
  1 files changed, 8 insertions(+), 6 deletions(-)
 
-diff --git a/gitk b/gitk
-index b523c98..18d000c 100755
---- a/gitk
-+++ b/gitk
+diff --git a/gitk-git/gitk b/gitk-git/gitk
+index b523c98..18d000c 100644
+--- a/gitk-git/gitk
++++ b/gitk-git/gitk
 @@ -22,11 +22,11 @@ proc gitdir {} {
  # run before X event handlers, so reading from a fast source can
  # make the GUI completely unresponsive.



Christian.
Previous: Alexander GavrilovNext: Christian Jaeger
Message 5 of 8 in “Revert "gitk: Arrange to kill diff-files & diff-index on quit"”
  1. Revert "gitk: Arrange to kill diff-files & diff-index on quit"Christian Jaeger, Aug 8, 2008
  2. Alexander GavrilovAug 9, 2008
  3. gitk: make diff and tree display work reliably againChristian Jaeger, Aug 9, 2008
  4. gitk: Allow safely calling nukefile from a run queue handler.Alexander Gavrilov, Aug 9, 2008
  5. Christian JaegerAug 9, 2008
  6. Christian JaegerAug 11, 2008
  7. Junio C HamanoAug 11, 2008
  8. Paul MackerrasAug 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.