git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG/PATCH] Revert "gitk: Arrange to kill diff-files & diff-index on quit"

From
Alexander Gavrilov <angavrilov@gmail.com>
Date
Aug 9, 2008, 09:13 UTC
Message-ID
<200808091313.52528.angavrilov@gmail.com>
In-Reply-To
<42d19ab224653b2e6988d7209a8d3e87e19858f8.1218207346.git.christian@jaeger.mine.nu>
On Friday 08 August 2008 18:41:07 Christian Jaeger wrote:
Show 5 quoted lines
> gitk would not show diffs (or trees when choosing tree view) about
> half of the times it is started, it would only show the commit
> messages. Sometimes it took dozens of times to get it to show a diff
> again with 3 starts, then the next 2 starts not, then the next 2
> starts would show it again, and so on.
> My system environment:
>   Debian Lenny (testing)
>   tk8.4 8.4.19-2

I cannot reproduce this on my Fedora 7 system with tk8.4.13 no matter how I try. Could you please try to isolate which hunk causes the problem? You should be able to remove them from bottom to top without any serious problems.

By the way, I experienced a similar problem while working on another patch (although it required a more elaborate sequence of actions to trigger it), and made a fix for it:

http://repo.or.cz/w/git.git?a=commitdiff;h=7272131b3e49879d3a7bedacad3cdb12ae678ee8
For some reason, now I cannot reproduce that either.
-- Alexander
Previous: Christian JaegerNext: Christian Jaeger
Message 2 of 8 in “Revert "gitk: Arrange to kill diff-files & diff-index on quit"”
  1. Revert "gitk: Arrange to kill diff-files & diff-index on quit"Christian Jaeger, Aug 8, 2008
  2. Alexander GavrilovAug 9, 2008
  3. gitk: make diff and tree display work reliably againChristian Jaeger, Aug 9, 2008
  4. gitk: Allow safely calling nukefile from a run queue handler.Alexander Gavrilov, Aug 9, 2008
  5. Christian JaegerAug 9, 2008
  6. Christian JaegerAug 11, 2008
  7. Junio C HamanoAug 11, 2008
  8. Paul MackerrasAug 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.