[PATCH] gitk: make diff and tree display work reliably again
- From
- Christian Jaeger <christian@jaeger.mine.nu>
- Date
- Aug 9, 2008, 10:04 UTC
- Message-ID
- <217ad8e755d8d51e2ec0f06b4bffa0864976f7e4.1218277122.git.christian@jaeger.mine.nu>
- In-Reply-To
- <200808091313.52528.angavrilov@gmail.com>
This reverts parts of the commit e439e092b8ee5248e92ed4cb4400f9dbed70f689.
gitk would not show diffs (or trees when choosing tree view) about half of the times it is started, it would only show the commit messages. Sometimes it took dozens of times to get it to show a diff again, then show it again the next 3 starts, then the next 2 starts not, then the next 2 starts would show it again, and so on.
The problem has been observed on Linux 2.6.26 x86_64 (Core 2 Duo), Debian lenny, tk8.4 8.4.19-2. (Playing with frequency scaling settings didn't show a difference; switching off one core made it more reproducible.)
Signed-off-by: Christian Jaeger <christian@jaeger.mine.nu> --- gitk-git/gitk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk index d093a39..216a3ce 100644 --- a/gitk-git/gitk +++ b/gitk-git/gitk @@ -4145,7 +4145,7 @@ proc readdifffiles {fd serial inst} { set isdiff 0 } # we only need to see one line and we don't really care what it says... - stop_instance $inst + close $fd if {$serial != $lserial} { return 0
-- 1.6.0.rc2.1.g42d19