Re: [PATCH] fix "git-submodule add a/b/c/repository"

From: Mark Levedahl <mlevedahl@gmail.com>
Date: Jul 8, 2008, 23:57 UTC
Message-ID: <4873FEF7.7000005@gmail.com>
In-Reply-To: <7vhcb0x6ak.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:

Show 6 quoted lines

> Thanks.
>
> The above is quite a bit more information than I can read from
> Documentation/git-submodule.txt; care to send it in in a patch form?
>
>

Will do, but I think it makes more sense to clean things up a bit so they are more explicable:

1) *require* two arguments for add: <URL> <relative-path-in-repo>
2) Remove one option for URL. Currently, we accept:
    a) absolute URL : origin is at URL
    b) top-level-relative URL (./foo | ../foo) : locates origin relative 
to top-level origin
    c) path-relative URL : locates origin relative to current working 
directory

I don't understand the use-case for item (c), and in any case it is easily replaced as an abolute url (e.g., $(pwd)/URL). So, I propose to restrict to (a) or (b) only, and reject (c).

I think these two changes in concert will reduce a lot of confusion without removing any real capability. Absent negative comments, I will prepare a patch to do this, *and* update the documentation to better define the options.

Mark