Re: [PATCH] fix "git-submodule add a/b/c/repository"

From: Sylvain Joyeux <sylvain.joyeux@dfki.de>
Date: Jul 7, 2008, 06:34 UTC
Message-ID: <20080707063424.GB5506@jhaampe.org>
In-Reply-To: <48711782.6090609@gmail.com>

On Sun, Jul 06, 2008 at 03:05:38PM -0400, Mark Levedahl wrote:

Show 14 quoted lines

> Sylvain Joyeux wrote:
>>  	git submodule add init dir0/dir1/init
>>     Would clone dir0/dir1/init at ./init and add ./init as a submodule. 
>> This is
>> actually what the current git-submodule (wrongly) does.
>>
>> Sylvain
>>   
> ...after some prep work...
>
> >git submodule add init dir0/dir1/init
> Adding existing repo at 'dir0/dir1/init' to the index
>
> So, what's the problem?

Redo the prep work, the clone and now

git submodule add dir0/dir1/init

(i.e. don't expect dir0/dir1/init to be the clone of ./init, that was just a shortcut for the test. Expect it to be a clone of "something, somewhere")

[~/tmp/test]% git-submodule add dir0/dir1/init Initialize init/.git Initialized empty Git repository in /home/doudou/tmp/test/init/.git/

[~/tmp/test]% git status # On branch master # Changes to be committed: # (use "git reset HEAD <file>..." to unstage) # # modified: .gitmodules # new file: init # # Untracked files: # (use "git add <file>..." to include in what will be committed) # # dir0/

What it is supposed to do (according to the documentation) is register dir0/dir1/init as the submodule, not clone it and register init/.

Sylvain