Re: [PATCH] fix "git-submodule add a/b/c/repository"

From: Sylvain Joyeux <sylvain.joyeux@dfki.de>
Date: Jul 8, 2008, 08:08 UTC
Message-ID: <20080708080848.GC3628@joyeux>
In-Reply-To: <4872DE54.5010804@gmail.com>

On Mon, Jul 07, 2008 at 11:26:12PM -0400, Mark Levedahl wrote:

Show 8 quoted lines

> Junio C Hamano wrote:
>> I'd like to hear clarifications on two counts, please?
>>  (1) If Sylvain wanted to have that appear at dir0/dir1/init not init,
>>      would it have been sufficient to give that path twice (once for
>>      <repository> and another for <path> parameter) to make things work as
>>      expected?
>>   
> git-submodule really requires two arguments:

Then it should raise an error when the following is given

  git submodule add ./relative-path-in-repo

which, for now, is accepted as

  git submodule add ./relative-path-in-repo ./relative-path-in-repo

(and confused me into thinking it was a normal behaviour)

Sylvain