[PATCH] builtin-gc.c: allow disabling all auto-gc'ing by assigning 0 to gc.auto
- From
Brandon Casey <casey@nrlssc.navy.mil>
- Date
- Mar 19, 2008, 21:53 UTC
- Message-ID
- <47E18B50.2080402@nrlssc.navy.mil>
- In-Reply-To
- <47E18540.4020908@nrlssc.navy.mil>
The gc.auto configuration variable is somewhat ambiguous now that there is also a gc.autopacklimit setting. Some users may assume that it controls all auto-gc'ing. Also, now users must set two configuration variables to zero when they want to disable autopacking. Since it is unlikely that users will want to autopack based on some threshold of pack files when they have disabled autopacking based on the number of loose objects, be nice and allow a setting of zero for gc.auto to disable all autopacking.
Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> --- builtin-gc.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin-gc.c b/builtin-gc.c index 95917d7..509bb9c 100644 --- a/builtin-gc.c +++ b/builtin-gc.c @@ -160,10 +160,10 @@ static int too_many_packs(void) static int need_to_gc(void) { /* - * Setting gc.auto and gc.autopacklimit to 0 or negative can - * disable the automatic gc. + * Setting gc.auto to 0 or negative can disable the + * automatic gc. */ - if (gc_auto_threshold <= 0 && gc_auto_pack_limit <= 0) + if (gc_auto_threshold <= 0) return 0; /*
-- 1.5.4.4.481.g5075