Re: [PATCH] builtin-gc.c: allow disabling all auto-gc'ing by assigning 0 to gc.auto

From: Teemu Likonen <tlikonen@iki.fi>
Date: Mar 20, 2008, 07:08 UTC
Message-ID: <200803200908.14061.tlikonen@iki.fi>
In-Reply-To: <47E18B50.2080402@nrlssc.navy.mil>

Brandon Casey kirjoitti:

Show 13 quoted lines

> The gc.auto configuration variable is somewhat ambiguous now that
> there is also a gc.autopacklimit setting. Some users may assume that
> it controls all auto-gc'ing. Also, now users must set two
> configuration variables to zero when they want to disable
> autopacking. Since it is unlikely that users will want to autopack
> based on some threshold of pack files when they have disabled
> autopacking based on the number of loose objects, be nice and allow a
> setting of zero for gc.auto to disable all autopacking.
>
> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
> ---
>  builtin-gc.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

This change should be documented in the git-gc.txt and config.txt. For example, the former currently says:

"Housekeeping is required if there are too many loose objects or too many packs in the repository. [...] Setting the value of `gc.auto` to 0 disables automatic packing of loose objects."

So, from the git-gc.txt's (current) point of view, gc.auto=0 does not touch the "or too many packs" part.