git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-cvsserver doesn't respect core.sharedrepository

From
Martin Langhoff <martin.langhoff@gmail.com>
Date
Mar 5, 2007, 05:15 UTC
Message-ID
<46a038f90703042115r3ce1498cmdddc0dc11c9d4b2a@mail.gmail.com>
In-Reply-To
<200702131821.37284.andyparkins@gmail.com>
On 2/14/07, Andy Parkins <andyparkins@gmail.com> wrote:
Show 9 quoted lines
> On Tuesday 2007, February 13, Johannes Schindelin wrote:
>
> > Ummm. What I tried to say is that this is intended behaviour, not bad
> > behaviour. The file does not have to have write permissions for the
> > group. The _directory_ has to have them.
>
> It's not just write permissions.  The default umask could also prevent
> read access by the group - the new ref needs to be readable by the
> group.

I agree. cvsserver depends on the user's umask just like an oldstyle cvs server. This is probably wrong, and you are right - we should respect core.sharedrepository.

The recent change to use git-update-ref should have fixed part of the problem. The other part of the problem is the handling of the sqlite files. All the other operations that leave permanent files in the repo are using git plumbing so we are safe.

To fix the sqlite files handling, the fix is to change the umask early on if core.sharedrepository is true.

cheers,
martin
Previous: Andy Parkins
Message 7 of 7 in “git-cvsserver doesn't respect core.sharedrepository”
  1. Andy ParkinsFeb 13, 2007
  2. Johannes SchindelinFeb 13, 2007
  3. Andy ParkinsFeb 13, 2007
  4. Nicolas PitreFeb 13, 2007
  5. Johannes SchindelinFeb 13, 2007
  6. Andy ParkinsFeb 13, 2007
  7. Martin LanghoffMar 5, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.