From: Martin Langhoff <martin.langhoff@gmail.com>
Date: Mon, 05 Mar 2007 05:15:43 GMT
Subject: Re: git-cvsserver doesn't respect core.sharedrepository
Message-ID: <46a038f90703042115r3ce1498cmdddc0dc11c9d4b2a@mail.gmail.com>
In-Reply-To: <200702131821.37284.andyparkins@gmail.com>

On 2/14/07, Andy Parkins <andyparkins@gmail.com> wrote:
> On Tuesday 2007, February 13, Johannes Schindelin wrote:
>
> > Ummm. What I tried to say is that this is intended behaviour, not bad
> > behaviour. The file does not have to have write permissions for the
> > group. The _directory_ has to have them.
>
> It's not just write permissions.  The default umask could also prevent
> read access by the group - the new ref needs to be readable by the
> group.

I agree. cvsserver depends on the user's umask just like an oldstyle
cvs server. This is probably wrong, and you are right - we should
respect core.sharedrepository.

The recent change to use git-update-ref should have fixed part of the
problem. The other part of the problem is the handling of the sqlite
files. All the other operations that leave permanent files in the repo
are using git plumbing so we are safe.

To fix the sqlite files handling, the fix is to change the umask early
on if core.sharedrepository is true.

cheers,


martin