Re: git-cvsserver doesn't respect core.sharedrepository
- From
Nicolas Pitre <nico@cam.org>
- Date
- Feb 13, 2007, 16:48 UTC
- Message-ID
- <Pine.LNX.4.64.0702131139490.1757@xanadu.home>
- In-Reply-To
- <200702131605.29088.andyparkins@gmail.com>
On Tue, 13 Feb 2007, Andy Parkins wrote:
Show 6 quoted lines
> That perhaps might be the explanation for the bad behaviour. The ref is being > updated in git-cvsserver by writing the new head hash into the lockfile then > doing > > unlink($reffile); > rename($lockfile, $reffile);
Wouldn't it be much better if it used git-update-ref instead? This manual ref updating looks like it has a potential for races to me.
Also git-update-ref should probably be used with -m to create reflog entries.
Nicolas