git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] cg-diff fixed to work with BSD xargs

From
Martin Langhoff <martin.langhoff@gmail.com>
Date
Sep 21, 2005, 10:56 UTC
Message-ID
<46a038f905092103561eac26a6@mail.gmail.com>
In-Reply-To
<pan.2005.09.21.07.33.14.533314@smurf.noris.de>
On 9/21/05, Matthias Urlichs <smurf@smurf.noris.de> wrote:
> I don't know what drugs your shell was on when you tested this (assuming
> that you did ;-)  but this patch is wrong -- your test always succeeds,
> due to the vagaries of test / [ ] semantics.

I've submitted test-time and commit-time urine tests to the relevant authorities. Both my shell and me are clean of forbidden substances ;-)

As Petr notes, the code is testing for a variable that we generated, not random user input. Yes, perhaps we should test $TMPDIR for sanity, but I think it's a bit overparanoid.

cheers,
martin
Previous: Matthias Urlichs
Message 9 of 9 in “cg-diff fixed to work with BSD xargs”
  1. cg-diff fixed to work with BSD xargsMartin Langhoff, Aug 30, 2005
  2. Junio C HamanoAug 30, 2005
  3. Petr BaudisSep 20, 2005
  4. Matthias UrlichsSep 21, 2005
  5. Petr BaudisSep 21, 2005
  6. Matthias UrlichsSep 21, 2005
  7. Petr BaudisSep 21, 2005
  8. Matthias UrlichsSep 21, 2005
  9. Martin LanghoffSep 21, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.