Re: [PATCH] cg-diff fixed to work with BSD xargs

From: Petr Baudis <pasky@suse.cz>
Date: Sep 20, 2005, 19:39 UTC
Message-ID: <20050920193956.GE28621@pasky.or.cz>
In-Reply-To: <7v7je3ld53.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Tue, Aug 30, 2005 at 04:20:40PM CEST, I got a letter where Junio C Hamano <junkio@cox.net> told me that...

Show 10 quoted lines

> But the code you are fixing looks to me like it is already
> somewhat obsolete, even if it is still working.  The munging of
> user-given paths into $filter temporary file was necessary only
> because older git-diff-* family did not work from anywhere but
> the top-level directory; they do, thanks to Linus' enhancements,
> these days.
> 
> I think it is time to start updating Cogito to take advantage of
> the modern core.  I do not do Porcelains, but here is my stab at
> it.

Thanks for the patch - it'd be actually very nice to get rid of the complexity. But more than that, I want to be consistent - so do all the GIT core commands work in subdirectories by now, or only a subset of them? I'd hate to have half of the scripts stay in the subdirectory and half use the Cogito's old relpath logic, so it's either everything or anything from my POV.

Thanks,

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.