From: Martin Langhoff <martin.langhoff@gmail.com>
Date: Wed, 21 Sep 2005 10:56:12 GMT
Subject: Re: [PATCH] cg-diff fixed to work with BSD xargs
Message-ID: <46a038f905092103561eac26a6@mail.gmail.com>
In-Reply-To: <pan.2005.09.21.07.33.14.533314@smurf.noris.de>

On 9/21/05, Matthias Urlichs <smurf@smurf.noris.de> wrote:
> I don't know what drugs your shell was on when you tested this (assuming
> that you did ;-)  but this patch is wrong -- your test always succeeds,
> due to the vagaries of test / [ ] semantics.

I've submitted test-time and commit-time urine tests to the relevant
authorities. Both my shell and me are clean of forbidden substances
;-)

As Petr notes, the code is testing for a variable that we generated,
not random user input. Yes, perhaps we should test $TMPDIR for sanity,
but I think it's a bit overparanoid.

cheers,


martin