git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sha1_file.c: Avoid multiple calls to find_pack_entry().

From
Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
Date
Jan 22, 2007, 20:56 UTC
Message-ID
<45B524E1.5060205@fs.ei.tum.de>
In-Reply-To
<20070122202945.GA29297@bohr.gbar.dtu.dk>
Peter Eriksen wrote:
Show 6 quoted lines
> We used to call find_pack_entry() twice from read_sha1_file() in order
> to avoid printing an error message, when the object did not exist.  This
> is fixed by moving the call to error() to the only place it really
> could be called.
> 
> Signed-off-by: Peter Eriksen <s022018@student.dtu.dk>
I noticed this originally, Peter was so kind to come up with a patch.  Reviewed and found +1, so:
Signed-off-by: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
cheers
  simon
-- 
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low €€€ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \
Previous: Peter EriksenNext: Shawn O. Pearce
Message 2 of 7 in “sha1_file.c: Avoid multiple calls to find_pack_entry().”
  1. sha1_file.c: Avoid multiple calls to find_pack_entry().Peter Eriksen, Jan 22, 2007
  2. Simon 'corecode' SchubertJan 22, 2007
  3. Shawn O. PearceJan 22, 2007
  4. Linus TorvaldsJan 23, 2007
  5. Jakub NarebskiJan 23, 2007
  6. Morten WelinderJan 23, 2007
  7. Linus TorvaldsJan 23, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.