From: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
Date: Mon, 22 Jan 2007 20:56:01 GMT
Subject: Re: [PATCH] sha1_file.c: Avoid multiple calls to find_pack_entry().
Message-ID: <45B524E1.5060205@fs.ei.tum.de>
In-Reply-To: <20070122202945.GA29297@bohr.gbar.dtu.dk>

Peter Eriksen wrote:
> We used to call find_pack_entry() twice from read_sha1_file() in order
> to avoid printing an error message, when the object did not exist.  This
> is fixed by moving the call to error() to the only place it really
> could be called.
> 
> Signed-off-by: Peter Eriksen <s022018@student.dtu.dk>

I noticed this originally, Peter was so kind to come up with a patch.  Reviewed and found +1, so:

Signed-off-by: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>

cheers
  simon

-- 
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low €€€ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \