Re: [PATCH] sha1_file.c: Avoid multiple calls to find_pack_entry().

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jan 22, 2007, 21:07 UTC
Message-ID: <20070122210719.GA29975@spearce.org>
In-Reply-To: <45B524E1.5060205@fs.ei.tum.de>

Simon 'corecode' Schubert <corecode@fs.ei.tum.de> wrote:

Show 12 quoted lines

> Peter Eriksen wrote:
> >We used to call find_pack_entry() twice from read_sha1_file() in order
> >to avoid printing an error message, when the object did not exist.  This
> >is fixed by moving the call to error() to the only place it really
> >could be called.
> >
> >Signed-off-by: Peter Eriksen <s022018@student.dtu.dk>
> 
> I noticed this originally, Peter was so kind to come up with a patch.  
> Reviewed and found +1, so:
> 
> Signed-off-by: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>

Wow.  That's ugly.  Thanks for finding and patching it.

-- 
Shawn.