git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] Implement poor-man's submodule support using commit hooks

From
Johannes Sixt <j.sixt@eudaptics.com>
Date
Dec 20, 2006, 13:29 UTC
Message-ID
<45893AC6.910D5748@eudaptics.com>
In-Reply-To
<200612201309.02119.andyparkins@gmail.com>
Andy Parkins wrote:
> +WORKINGTOP=$(git-rev-parse --show-cdup)
> +GITMODULES="${WORKINGTOP}.gitmodules"
> +if [ -f "$GITMODULES" ]; then
> +       cat "$GITMODULES" |
useless-use-of-cat-syndrome
> +       while read subdir hash

Wouldn't it be better to have the order of subdir and hash swapped? That way subdir may contain blanks, and it gives nicer alignment in the file because of the constant length of the hashes.

-- Hannes
Previous: Andy ParkinsNext: Andy Parkins
Message 2 of 14 in “Implement poor-man's submodule support using commit hooks”
  1. Implement poor-man's submodule support using commit hooksAndy Parkins, Dec 20, 2006
  2. Johannes SixtDec 20, 2006
  3. Andy ParkinsDec 20, 2006
  4. Jakub NarebskiDec 20, 2006
  5. Andy ParkinsDec 20, 2006
  6. Rogan DawesDec 20, 2006
  7. Andy ParkinsDec 20, 2006
  8. Randal L. SchwartzDec 20, 2006
  9. Johannes SchindelinDec 20, 2006
  10. Martin WaitzDec 20, 2006
  11. Andy ParkinsDec 20, 2006
  12. Andy ParkinsDec 20, 2006
  13. Martin WaitzDec 20, 2006
  14. Johannes SixtDec 20, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.