From: Johannes Sixt <j.sixt@eudaptics.com>
Date: Wed, 20 Dec 2006 13:29:42 GMT
Subject: Re: [RFC/PATCH] Implement poor-man's submodule support using commit hooks
Message-ID: <45893AC6.910D5748@eudaptics.com>
In-Reply-To: <200612201309.02119.andyparkins@gmail.com>

Andy Parkins wrote:
> +WORKINGTOP=$(git-rev-parse --show-cdup)
> +GITMODULES="${WORKINGTOP}.gitmodules"
> +if [ -f "$GITMODULES" ]; then
> +       cat "$GITMODULES" |

useless-use-of-cat-syndrome

> +       while read subdir hash

Wouldn't it be better to have the order of subdir and hash swapped? That
way subdir may contain blanks, and it gives nicer alignment in the file
because of the constant length of the hashes.

-- Hannes