Re: bug: git-sh-setup should not be in $PATH

From: Han-Wen Nienhuys <hanwen@xs4all.nl>
Date: Dec 6, 2006, 16:40 UTC
Message-ID: <4576F29B.6010105@xs4all.nl>
In-Reply-To: <200612061727.54058.jnareb@gmail.com>

Jakub Narebski escreveu:

Show 16 quoted lines

>> there should be Makefiles in said directories. Otherwise, every rule
>> in the toplevel Makefile saying
>>
>>
>>   $(MAKE) -C subdir/
>>
>> will fail because $builddir/ does not have a Makefile in
>> $builddir/subdir.
> 
> Wouldn't it be better just to modify toplevel Makefile to say:
> 
>    $(MAKE) -C $(srcdir)/subdir/
> 
> without messing with ./configure script, and creating "redirect"
> Makefiles?
>

that doesn't work.

  make -C foo bla

just does

  (cd foo && make bla)

If you did this, part of the object files would end up in the source dir; The idea of separate srcdir builds,is to keep the srcdir completely clean of generated files. That can't really be done without aid of a script, to setup the builddir. In this case that is the configure script.

I did forget to add a check

  if "$srcdir" != "." ; then
    ..
  fi

around the messy stuff.

-- 
 Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen