Re: bug: git-sh-setup should not be in $PATH

From: Han-Wen Nienhuys <hanwen@xs4all.nl>
Date: Dec 6, 2006, 15:36 UTC
Message-ID: <4576E38F.1020404@xs4all.nl>
In-Reply-To: <200612061627.40359.jnareb@gmail.com>

Jakub Narebski escreveu:

Show 5 quoted lines

> Still I think that at least
> 
>   datarootdir = @datarootdir@
> 
> should be not removed.

yes, agreed.

>>>> +  if test -f $srcdir/$d/Makefile ; then

  [..]

>>>> +    echo creating $d/Makefile
>>>> +    cat << EOF> $d/Makefile

>>> This part IMHO has no sense, and has no place here.
> 
> If you want to create or modify Makefiles, do that. Not generate
> "minimal" Makefiles in every and each subdirectory.

Look more closely at the patch. It only generates Makefiles in directories that have makefiles in the source dir. The makefiles are short because that is the easiest to do.

I'm happy to amend the patch, bUt I can't properly test it until the perl problem gets sorted out.

-- 
 Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen